-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: template correction for 7mode #531
Conversation
@@ -14,7 +14,7 @@ counters: | |||
- KB_copied => kb_copied | |||
|
|||
override: | |||
- KB_copied: delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u also check on cmode? Could you also run yaml validator on these yamls if it can identify the issue we saw in logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, yaml validator can identify the indentation issue. cmode yamls are fine.
hardikl@hardikl-mac-0 harvest % yamllint conf/zapiperf/7mode/8.2.5/copy_manager.yaml
conf/zapiperf/7mode/8.2.5/copy_manager.yaml
1:1 warning missing document start "---" (document-start)
1:26 error too many spaces after colon (colons)
2:26 error too many spaces after colon (colons)
3:26 error too many spaces after colon (colons)
5:26 error too many spaces after colon (colons)
17:2 error wrong indentation: expected 2 but found 1 (indentation)
Ran for all yamls, but the result is little different.
example:
for zapi's field and sub field, it's recognising the issue but we didn't get any issue from this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use yamllint -d relaxed
to ignore the superfluous messages
handle for these 2:
-> 11:44AM ERR goharvest2/cmd/collectors/zapi/collector/zapi.go:108 > Error importing subtemplate: copy_manager.yaml error="invalid indentation, line: 17" Poller=cluster-04 collector=ZapiPerf:CopyManager
-> 11:44AM ERR goharvest2/cmd/collectors/zapi/collector/zapi.go:321 > metric (diagnosis-config-info.mon-version) set value (2.0): strconv.ParseUint: parsing "2.0": invalid syntax Poller=cluster-04 collector=Zapi:Status_7mode