Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template correction for 7mode #531

Merged
merged 5 commits into from
Oct 1, 2021
Merged

fix: template correction for 7mode #531

merged 5 commits into from
Oct 1, 2021

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Sep 29, 2021

handle for these 2:

-> 11:44AM ERR goharvest2/cmd/collectors/zapi/collector/zapi.go:108 > Error importing subtemplate: copy_manager.yaml error="invalid indentation, line: 17" Poller=cluster-04 collector=ZapiPerf:CopyManager

-> 11:44AM ERR goharvest2/cmd/collectors/zapi/collector/zapi.go:321 > metric (diagnosis-config-info.mon-version) set value (2.0): strconv.ParseUint: parsing "2.0": invalid syntax Poller=cluster-04 collector=Zapi:Status_7mode

@cla-bot cla-bot bot added the cla-signed label Sep 29, 2021
@Hardikl Hardikl linked an issue Sep 29, 2021 that may be closed by this pull request
@@ -14,7 +14,7 @@ counters:
- KB_copied => kb_copied

override:
- KB_copied: delta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u also check on cmode? Could you also run yaml validator on these yamls if it can identify the issue we saw in logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yaml validator can identify the indentation issue. cmode yamls are fine.

hardikl@hardikl-mac-0 harvest % yamllint conf/zapiperf/7mode/8.2.5/copy_manager.yaml
conf/zapiperf/7mode/8.2.5/copy_manager.yaml
1:1 warning missing document start "---" (document-start)
1:26 error too many spaces after colon (colons)
2:26 error too many spaces after colon (colons)
3:26 error too many spaces after colon (colons)
5:26 error too many spaces after colon (colons)
17:2 error wrong indentation: expected 2 but found 1 (indentation)

Ran for all yamls, but the result is little different.
example:
for zapi's field and sub field, it's recognising the issue but we didn't get any issue from this.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use yamllint -d relaxed to ignore the superfluous messages

rahulguptajss
rahulguptajss previously approved these changes Sep 29, 2021
cgrinds
cgrinds previously approved these changes Sep 29, 2021
@Hardikl Hardikl dismissed stale reviews from cgrinds and rahulguptajss via c5cd58f September 30, 2021 10:29
@Hardikl Hardikl mentioned this pull request Sep 30, 2021
pkg/dict/dict.go Outdated Show resolved Hide resolved
@Hardikl Hardikl merged commit 893d0df into main Oct 1, 2021
@Hardikl Hardikl deleted the testing branch October 1, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7-mode template issues
3 participants