feat: Template merge functionality #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
requested review from
cdurai-netapp,
cgrinds,
Hardikl and
vgratian
as code owners
Hardikl
reviewed
Sep 16, 2021
|
Refer https://github.com/NetApp/harvest-private/wiki/Template-Merge about the functionality |
cgrinds
reviewed
Sep 20, 2021
|
addressed review comments |
rahulguptajss
force-pushed
the
rg2-merge-template-0809
branch
from
9797905 to
0841711
Compare
rahulguptajss
force-pushed
the
rg2-merge-template-0809
branch
from
0841711 to
c58def5
Compare
cgrinds
reviewed
Sep 22, 2021
pkg/tree/node/node.go
Outdated
| func fetchRoot(source *Node) *Node { | ||
| if source != nil && source.GetParent() != nil && source.GetParent().GetNameS() == "Root" { | ||
| return source | ||
| func (n *Node) fetchRoot() *Node { |
|
addressed review comments. |
cgrinds
approved these changes
Sep 23, 2021
|
docs need to be consolidated and updated to reflect this change and how to use it:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.