Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ontap rest collector #502

Closed
wants to merge 1 commit into from
Closed

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 14, 2021
@rahulguptajss rahulguptajss changed the title Ontap rest collector ontap rest collector Sep 14, 2021
@rahulguptajss rahulguptajss changed the title ontap rest collector feat: ontap rest collector Sep 14, 2021
@cgrinds
Copy link
Collaborator

cgrinds commented Sep 23, 2021

See also #402

Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vgratian and @rahulguptajss this is a great start
In addition to the outstanding issues raised in #402 we also need to think more about ZAPI and REST selection algorithm. The node based creator code should be replaced with the struct based cmd/tools/rest/client.go

@rahulguptajss rahulguptajss marked this pull request as draft October 11, 2021 09:29
@cla-bot cla-bot bot removed the cla-signed label Oct 11, 2021
@rahulguptajss rahulguptajss removed the request for review from vgratian October 11, 2021 11:41
@rahulguptajss
Copy link
Contributor Author

resolved merge conflicts.

1: Working on client.go consolidation
2: Pass fields in rest calls.

@rahulguptajss
Copy link
Contributor Author

WIP. I'll move it PR to active when ready for review.

@rahulguptajss
Copy link
Contributor Author

@cla-bot check

@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@NetApp NetApp deleted a comment from cla-bot bot Oct 11, 2021
@cla-bot
Copy link

cla-bot bot commented Oct 12, 2021

Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request.
After signing the CCLA, you can ask us to recheck this PR by posting @cla-bot check as a comment to the PR.

2 similar comments
@cla-bot
Copy link

cla-bot bot commented Oct 12, 2021

Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request.
After signing the CCLA, you can ask us to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Oct 13, 2021

Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request.
After signing the CCLA, you can ask us to recheck this PR by posting @cla-bot check as a comment to the PR.

@rahulguptajss
Copy link
Contributor Author

Squashed all commits into one for clean start of PR. Marking PR active for review.

@rahulguptajss rahulguptajss marked this pull request as ready for review October 13, 2021 06:55
@vgratian
Copy link
Contributor

Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. After signing the CCLA, you can ask us to recheck this PR by posting @cla-bot check as a comment to the PR.

I signed the CCLA, also just in case you think I could help, just mention me anywhere, whenever I am able I would love to contribute. Good luck!

@cla-bot
Copy link

cla-bot bot commented Oct 13, 2021

The cla-bot has been summoned, and re-checked this pull request!

@rahulguptajss
Copy link
Contributor Author

rahulguptajss commented Oct 13, 2021

@ruanruijuan does @vgratian need to sign ccla again?

@rahulguptajss rahulguptajss deleted the ontap-rest-collector branch November 30, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants