-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ontap rest collector #502
Conversation
See also #402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @vgratian and @rahulguptajss this is a great start
In addition to the outstanding issues raised in #402 we also need to think more about ZAPI and REST selection algorithm. The node based creator code should be replaced with the struct based cmd/tools/rest/client.go
85fb73c
to
cd822d9
Compare
resolved merge conflicts. 1: Working on client.go consolidation |
WIP. I'll move it PR to active when ready for review. |
@cla-bot check |
Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. |
2 similar comments
Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. |
Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @vgratian on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. |
d731315
to
0f6a016
Compare
3465e91
to
7af03b7
Compare
Squashed all commits into one for clean start of PR. Marking PR active for review. |
I signed the CCLA, also just in case you think I could help, just mention me anywhere, whenever I am able I would love to contribute. Good luck! |
The cla-bot has been summoned, and re-checked this pull request! |
@ruanruijuan does @vgratian need to sign ccla again? |
No description provided.