Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split dashboards for 7mode - part1 #489

Merged
merged 1 commit into from
Sep 6, 2021
Merged

feat: split dashboards for 7mode - part1 #489

merged 1 commit into from
Sep 6, 2021

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Sep 2, 2021

Added global label only in 7mode node.yaml, we would use the node_labels{system_type} to take decision of cmode/7mode.

Identified gaps:

  • 7 mode don't have product-version in system-get-info zapi
  • 7 mode don't have tx_hw_errors, rx_alignment_errors, rx_crc_errors, rx_length_errors in nic_common object

Changes done:
Cluster

  • node_new_status to cluster_new_status

Aggregate

  • Physical Space Used to space used
  • removed Capacity Tier Used(aggr_space_capacity_tier_used), Data Compaction space used(aggr_space_data_compaction_saved), Space Reserved for Snapshot %(space reserved for snapshot) panels which are nor available in 7 mode zapi response.

Network

  • Removed Transmission interrupts, Transmission errors, Link Down, Link Failure panels

Network with Nvme/FC

  • Removed Nvme/FC receive, Nvme/FC send, Transmission interrupts, Transmission errors, Link Down, Link Failure panels, Nvme/Fc ports table

@Hardikl
Copy link
Contributor Author

Hardikl commented Sep 2, 2021

cmode dashboard would show only cmode datacenter
image

7mode dashboard would show only 7mode datacenter
image

image

@cgrinds
Copy link
Collaborator

cgrinds commented Sep 2, 2021

Looks good @Hardikl - as discussed in chat, dropping here so we don't forget. If customers have customized dashboards and they don't update the queries in those dashboards (as done in this PR), then they will still see 7-mode clusters in their custom dashboards

@Hardikl Hardikl merged commit 9d159b5 into main Sep 6, 2021
@Hardikl Hardikl deleted the dash_split branch September 6, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create distinct set of 7-mode dashboards separate from c-mode
2 participants