Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lun, node and volume details dashboard #458

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

cgrinds
Copy link
Collaborator

@cgrinds cgrinds commented Aug 26, 2021

Thanks to Jeff Asher for sharing these!

Fabricpool isn't working in any of these yet.

@cla-bot cla-bot bot added the cla-signed label Aug 26, 2021
@cgrinds cgrinds force-pushed the jeff-cpoc-dashboards branch from 3e1dd73 to dbbc5fb Compare August 26, 2021 19:54
@cgrinds cgrinds changed the title feat: add lun and volume details dashboard feat: add lun, node and volume details dashboard Aug 26, 2021
@cgrinds cgrinds force-pushed the jeff-cpoc-dashboards branch from dbbc5fb to 3b8deb7 Compare August 27, 2021 00:56
Thanks to Jeff Asher for sharing these!

Fabricpool isn't working in any of these yet.
@cgrinds cgrinds force-pushed the jeff-cpoc-dashboards branch from 3b8deb7 to 272d3a5 Compare August 27, 2021 00:58
@vgratian
Copy link
Contributor

Awesome, finally some proper dashboards!

I tested on Grafana v8.1.1 (90c87a52f7). A few issues or comments:

NetApp Detail: Node - Ready for Export

  • (comment) the Node Uptime, Node Fan Status and Node Power Status are fine when you have 2-3 nodes, but harder to read with more nodes: we might want to convert them into a table in the future.
  • Ethernet Port Utilization Percent and FC Port Utilization Percent: unit should be `Percent (0.0-1.0): this is inaccurate in our Network dashboard as well)
  • In the Panel NFSv3 Frontend Drilldown:
    ** graphs have node="$Node" in the query, this should be node=~"$Node", otherwise we see only data when one node is selected
    ** avg(node_nfs_latency{datacenter="$Datacenter",cluster="$Cluster",node="$Node",nfsv="v3"}) / 1000 - division is redundant, just change the unit from milliseconds to microseconds

@vgratian
Copy link
Contributor

NetApp Detail: Volume Details

  • In the panel Per Volume Statistics: most graphs have bad legends, see my screenshot:
    Screenshot from 2021-08-27 15-03-51
    This can be improved by adding labels in under the queries.

@vgratian
Copy link
Contributor

I fixed the issues mentioned above.

One issue that I noticed: in the Volume Detail dashboards, in the Per Volume Snapshot Space Used Percent graph, percentages are higher than 100%. Seems like this is an issue on its own, since metrics themselves are higher than 100%.

@vgratian
Copy link
Contributor

vgratian commented Aug 27, 2021

screenshot:

Screenshot from 2021-08-27 18-35-27

@cgrinds cgrinds merged commit 75b2f5b into release/21.08.0 Aug 27, 2021
@cgrinds cgrinds deleted the jeff-cpoc-dashboards branch August 27, 2021 15:01
@cgrinds
Copy link
Collaborator Author

cgrinds commented Aug 27, 2021

Thanks Jeff for contributing these and @vgratian for the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants