Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove uses of nolint:gocritic #3299

Merged
merged 1 commit into from
Nov 18, 2024
Merged

refactor: remove uses of nolint:gocritic #3299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/collectors/rest/plugins/volumeanalytics/volumeanalytics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func (v *VolumeAnalytics) Run(dataMap map[string]*matrix.Matrix) ([]*matrix.Matr
}
}

if len(atBytesUsedValues) == len(atBytesUsedPercentages) && len(atBytesUsedValues) == len(atBytesUsedLabels) { //nolint:gocritic
if len(atBytesUsedValues) == len(atBytesUsedPercentages) && len(atBytesUsedPercentages) == len(atBytesUsedLabels) {

for i, av := range atBytesUsedValues {
if av == "" {
Expand Down
3 changes: 1 addition & 2 deletions cmd/harvest/harvest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,7 @@ func startPoller(pollerName string, promPort int, opts *options) {
// Start the poller process in the background
if err := cmd.Start(); err != nil {
fmt.Println(err)
closeDevNull(devNull) // os.Exit means closeDevNull will not run so call directly
os.Exit(1) //nolint:gocritic
defer os.Exit(1)
}
}

Expand Down