-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linking dashboard part-1 #2931
Conversation
|
# Conflicts: # cmd/tools/grafana/dashboard_test.go
Changes covered so far:
|
Tested in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Grafana has a flat namespace and folders don't really exist, perhaps we should simplify the uids like so:
harvest-cdot-aggregate => cdot-aggregate
harvest-cdot-details-volume-by-svm => cdot-volume-by-svm
harvest-storagegrid-overview => storagegrid-overview
cmd/tools/grafana/grafana.go
Outdated
m[filepath.Join(opts.dir, "cmode", "details")] = &Folder{name: "Harvest-" + harvestRelease + "-cDOT Details"} | ||
m[filepath.Join(opts.dir, "7mode")] = &Folder{name: "Harvest-" + harvestRelease + "-7mode"} | ||
m[filepath.Join(opts.dir, "storagegrid")] = &Folder{name: "Harvest-" + harvestRelease + "-StorageGrid"} | ||
m[filepath.Join(opts.dir, "cmode")] = &Folder{name: "Harvest-main-cDOT"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're ditching versioned folders maybe Harvest-cDOT
, Harvest-StorageGrid
, etc. would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I was just matching the behaviour with what our docker workflow currently doing.
Added the naming convention this way. |
* feat: linking dashboard: volume, aggr and svm with test * feat: handling review comments
No description provided.