style: improving Debug Log Clarity and Reducing Noise #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the logs shared by Tony earlier, found that the following logs are being generated frequently and do not seem useful at the debug level.
2516825 nabox-harvest2 | 2024-03-12T08:17:11Z DBG disk/disk.go:901 > failed to parse value error="strconv.ParseFloat: parsing "-": invalid syntax" Poller=metricKey=fan-rpm object=Disk plugin=ZapiPerf:Disk value=-
569724 nabox-harvest2 | --- DBG --- > --- --- data --- --- --- --- ---
417831 nabox-harvest2 | 2024-03-12T08:15:57Z DBG zapiperf/zapiperf.go:1669 > instances Poller=collector=ZapiPerf:FCVI new=0 removed=0 total=0
261276 nabox-harvest2 | --- DBG --- > --- --- --- --- --- ---
131129 nabox-harvest2 | 2024-03-12T08:15:59Z DBG collector/collector.go:509 > skipped non-exportable data Poller=UUID=Rest collector=Rest:Health object=health
102820 nabox-harvest2 | 2024-03-12T08:15:56Z DBG poller/poller.go:493 > exporter (nabox-prometheus) status: (0 - up) initialized Poller=
101148 nabox-harvest2 | 2024-03-12T08:16:57Z DBG volume/volume.go:129 > extracted 0 flexgroup volumes Poller=object=Volume plugin=ZapiPerf:Volume
47628 nabox-harvest2 | 2024-03-12T08:15:56Z DBG svm/svm.go:128 > Failed to collect audit protocols error="no instances => no records found" Poller=object=SVM plugin=Zapi:SVM
35907 nabox-harvest2 | 2024-03-12T08:15:56Z DBG zapiperf/zapiperf.go:1194 > Adding missing base counter Poller=collector=ZapiPerf:HeadroomAggr name=current_utilization_total
33806 nabox-harvest2 | 2024-03-12T08:15:56Z DBG aggregate/aggregate.go:54 > Failed to collect cloud store data error="no instances => no records found" Poller=object=Aggregate plugin=Zapi:Aggregate
33565 nabox-harvest2 | 2024-03-12T08:15:57Z DBG qtree/qtree.go:203 > no quota instances found Poller=object=Qtree plugin=Zapi:Qtree
23354 nabox-harvest2 | --- DBG --- > --- --- --- --- --- ---
20639 nabox-harvest2 | 2024-03-12T08:15:56Z DBG collector/collector.go:354 > handling error during [data] poll... Poller=collector=Zapi:CloudTarget
17414 nabox-harvest2 | 2024-03-12T08:15:50Z DBG zapiperf/zapiperf.go:344 > using batch_size = [500] (default) Poller=collector=ZapiPerf:NFSv4
16898 nabox-harvest2 | 2024-03-12T08:16:00Z DBG ems/ems.go:363 > starting data poll Poller=collector=Ems:Ems