Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Harvest should reduce batch size and retry when ONTAP times out #2770

Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat: Harvest should reduce batch size and retry when ONTAP times out #2770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
149999c
feat: Harvest should reduce batch size and retry when ONTAP times out
cgrinds Mar 22, 2024
7ecc80f
feat: Harvest should reduce batch size and retry when ONTAP times out
cgrinds Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cmd/collectors/zapiperf/zapiperf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,14 +463,22 @@ func (z *ZapiPerf) PollData() (map[string]*matrix.Matrix, error) {

response, rd, pd, err := z.Client.InvokeWithTimers(z.testFilePath)
if err != nil {
errMsg := err.Error()
// if ONTAP complains about batch size, use a smaller batch size
if strings.Contains(err.Error(), "resource limit exceeded") && z.batchSize > 100 {
if strings.EqualFold(errMsg, "resource limit exceeded") && z.batchSize > 100 {
z.Logger.Error().Err(err).
Int("oldBatchSize", z.batchSize).
Int("newBatchSize", z.batchSize-100).
Msg("Changed batch_size")
z.batchSize -= 100
return nil, nil
} else if strings.EqualFold(errMsg, "Timeout: Operation") && z.batchSize > 100 {
z.Logger.Error().Err(err).
Int("oldBatchSize", z.batchSize).
Int("newBatchSize", z.batchSize-100).
Msg("ONTAP timeout, reducing batch size")
z.batchSize -= 100
return nil, nil
}
return nil, err
}
Expand Down
Loading