fix: rest collector should include endpoint api_times
#2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest collector's `api_time` only records how long it took for the first query in the rest template to execute, ignoring any endpoint times. Templates with multiple endpoints undercount the `api_time`. This pull request fixes the bug by including all endpoints `api_time`s in the reported `api_time`.
Hardikl
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest collector's
api_timeonly records how long it took for the first query in the rest template to execute, ignoring any endpoint times. Templates with multiple endpoints undercount theapi_time. This pull request fixes the bug by including all endpointsapi_times in the reportedapi_time.Thanks to Christopher Wilcox for reporting