feat: Adding new panels in Disk dashboard #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cgrinds
previously approved these changes
Sep 29, 2023
grafana/dashboards/cmode/disk.json
Outdated
| "format": "time_series", | ||
| "instant": false, | ||
| "interval": "", | ||
| "legendFormat": "{{disk}}", |
There was a problem hiding this comment.
Seems like only new panels support raid and plex filtering which is not very clear from the UI.
There was a problem hiding this comment.
Yes, May be I could add new panes in new row and row name should specify that Top Disks: Raid-level overview.
Any suggestion?
There was a problem hiding this comment.
added in separate panels.
|
cgrinds
reviewed
Oct 3, 2023
cgrinds
previously approved these changes
Oct 3, 2023
grafana/dashboards/cmode/disk.json
Outdated
| "format": "time_series", | ||
| "instant": false, | ||
| "interval": "", | ||
| "legendFormat": "{{cluster}} - {{disk}}", |
There was a problem hiding this comment.
Should raid/flex be displayed in legend?
rahulguptajss
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.