Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct svm rest template based on version #2239

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmd/collectors/rest/plugins/svm/svm.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,10 @@ func (my *SVM) Run(dataMap map[string]*matrix.Matrix) ([]*matrix.Matrix, error)
svmInstance.SetLabel("iscsi_authentication_type", iscsiAuthenticationType)
}

ciphersVal := svmInstance.GetLabel("ciphers")
insecured := weakCiphers.MatchString(ciphersVal)
svmInstance.SetLabel("insecured", strconv.FormatBool(insecured))
if ciphersVal := svmInstance.GetLabel("ciphers"); ciphersVal != "" {
insecured := weakCiphers.MatchString(ciphersVal)
svmInstance.SetLabel("insecured", strconv.FormatBool(insecured))
}
}
return nil, nil
}
Expand Down
File renamed without changes.
81 changes: 81 additions & 0 deletions conf/rest/9.9.0/svm.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
# As private cli api would provide all svms(but system) which we would need for our use-case, So using private api instead of public.

name: SVM
query: api/private/cli/vserver
object: svm

counters:
- ^^vserver => svm
- ^operational_state => state
- ^type => type

endpoints:
- query: api/svm/svms
counters:
- ^^name => svm
- ^nsswitch => nameservice_switch
- query: api/protocols/cifs/services
counters:
- ^^svm.name => svm
- ^enabled => cifs_protocol_enabled
- ^security.smb_encryption => smb_encryption_required
- ^security.smb_signing => smb_signing_required
- query: api/protocols/nfs/services
counters:
- ^^svm.name => svm
- ^enabled => nfs_protocol_enabled
- query: api/protocols/audit
counters:
- ^^svm.name => svm
- ^enabled => audit_protocol_enabled
- query: api/name-services/nis
counters:
- ^^svm.name => svm
- ^domain => nis_domain
- query: api/name-services/ldap
counters:
- ^^svm.name => svm
- ^session_security => ldap_session_security
- query: api/private/cli/vserver/cifs/server/security
counters:
- ^^vserver => svm
- ^lm_compatibility_level => cifs_ntlm_enabled

plugins:
- SVM
- LabelAgent:
replace:
- type root_svm `data` `No`
- type root_svm `node` `Yes`
- type root_svm `admin` `Yes`
- type root_svm `system` `Yes`
value_to_num:
- new_status state online online `0`
- ldap_signed ldap_session_security sign sign `0`
- ldap_encrypted ldap_session_security seal seal `0`

export_options:
instance_keys:
- svm
instance_labels:
- audit_protocol_enabled
- cifs_ntlm_enabled
- cifs_protocol_enabled
- fpolicy_enabled
- fpolicy_name
- insecured
- iscsi_authentication_type
- iscsi_service_enabled
- ldap_session_security
- nfs_kerberos_protocol_enabled
- nfs_protocol_enabled
- nis_authentication_enabled
- nis_domain
- ns_db
- ns_source
- root_svm
- smb_encryption_required
- smb_signing_required
- state
- type