feat: autoresolve ems would export metric value as 0 and autoresolve=true label #2120
Conversation
Hardikl
commented
Jun 1, 2023
Hardikl
commented
|
We should update the documentation to define the autoresolve label |
Added doc changes for this. |
cmd/collectors/ems/ems.go
Outdated
| @@ -41,6 +42,7 @@ type Ems struct { | |||
| eventNames []string // consist of all ems events supported | |||
| bookendEmsMap map[string]*set.Set // This is reverse bookend ems map, [Resolving ems]:[Set of Issuing ems]. Using Set here to ensure that it has slice of unique issuing ems | |||
| resolveAfter map[string]time.Duration // This is resolve after map, [Issuing ems]:[Duration]. After this duration, ems got auto resolved. | |||
| autoresolved bool | |||
There was a problem hiding this comment.
How can a single variable autoresolve is handling multiple matrix containing EMS messages? This single var state seems wrong at Collector level. This should be at ems level?
There was a problem hiding this comment.
Now, it's not needed as it would export e.Matrix with instance exported=true/false and work as expected.
|
Few corrections:
|
| @@ -652,7 +643,16 @@ func (e *Ems) HandleResults(result []gjson.Result, prop map[string][]*emsProp) ( | |||
| count += instanceLabelCount | |||
| } | |||
| } | |||
| return m, count | |||
|
|
|||
There was a problem hiding this comment.
Can we calculate instanceCount in the above loops above, so we don't have to loop through all instances of all matrices again here?
There was a problem hiding this comment.
It's added here mainly for autoresolve case.
In that case, we haven't get any records from ONTAP, so it won't run the above loop, but still we want to export 1 instance which would be resolved based on time.
Logging issue is resolved in this PR at 404-407 lines. |
|
Matches label counts when multiple ems with same name exist would be handled in next PR |
