fix: change svm panels row name #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some limitations while exploring repeat panels. Here are the issues I encountered:
Each timeseries panel requires its own separate variable, such as
TopNfsv3ReadAvgLatencyandTopNfsv4ReadAvgLatency. I couldn't find a way to make this dynamic to different scenarios.The NFsv3 row includes histograms, but I chose not to add histograms to other NFS versions in order to avoid exporting excessive data. However, if a user specifically requests it, we can consider adding histograms in the future.
In order to maintain consistency with other panels, I simply changed the row name to make it similar to the others.