-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: simplify counter validation #1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: ignore non Harvest error messages
With missing countersChanged 1:02PM INF dashboard_json_test.go:184 > Dashboard validation completed dur=10.492s failed=10 numCounters=43 path=cmode/aggregate.json
1:02PM INF dashboard_json_test.go:204 > Dashboard Json validated durMs=4m22.099s exprIgnored=354 numCounters=648 restFails=5 zapiFails=5
--- FAIL: TestJsonExpression (262.10s)
dashboard_json_test.go:162: REST counter=foo path=cmode/aggregate.json not in DB expr=sum(count(foo{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"}) by (aggr))
dashboard_json_test.go:167: ZAPI counter=foo path=cmode/aggregate.json not in DB expr=sum(count(foo{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"}) by (aggr))
dashboard_json_test.go:175: query validation failed counters=foo expr=sum(count(foo{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"}) by (aggr))
dashboard_json_test.go:162: REST counter=foople path=cmode/aggregate.json not in DB expr=sum(foople{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:167: ZAPI counter=foople path=cmode/aggregate.json not in DB expr=sum(foople{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:175: query validation failed counters=foople expr=sum(foople{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:162: REST counter=star path=cmode/aggregate.json not in DB expr=sum(star{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:167: ZAPI counter=star path=cmode/aggregate.json not in DB expr=sum(star{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:175: query validation failed counters=star expr=sum(star{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:162: REST counter=moon path=cmode/aggregate.json not in DB expr=sum(moon{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:167: ZAPI counter=moon path=cmode/aggregate.json not in DB expr=sum(moon{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:175: query validation failed counters=moon expr=sum(moon{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:162: REST counter=flow path=cmode/aggregate.json not in DB expr=sum(flow{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:167: ZAPI counter=flow path=cmode/aggregate.json not in DB expr=sum(flow{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:175: query validation failed counters=flow expr=sum(flow{datacenter=~"$Datacenter",cluster=~"$Cluster",node=~"$Node",aggr=~"$Aggregate"})
dashboard_json_test.go:188: Rest validation failures=5
dashboard_json_test.go:194: Zapi validation failures=5
FAIL
FAIL github.com/Netapp/harvest-automation/test 295.030s
________________________________________________________
Executed in 340.71 secs fish external
usr time 7.02 secs 0.22 millis 7.02 secs
sys time 6.80 secs 1.22 millis 6.80 secs With no missing counters1:27PM INF dashboard_json_test.go:204 > Dashboard Json validated durMs=3m51.25s exprIgnored=354 numCounters=648 restFails=0 zapiFails=0 |
rahulguptajss
previously approved these changes
Apr 19, 2023
ci: ignore non Harvest error messages
rahulguptajss
previously approved these changes
Apr 19, 2023
ci: ignore non Harvest error messages ci: enable debug log on Grafana
ci: ignore non Harvest error messages ci: enable debug log on Grafana ci: improve Grafana logging
rahulguptajss
approved these changes
Apr 20, 2023
Hardikl
approved these changes
Apr 20, 2023
Hardikl
pushed a commit
that referenced
this pull request
Apr 21, 2023
* ci: simplify counter validation ci: ignore non Harvest error messages * ci: simplify counter validation ci: ignore non Harvest error messages * ci: simplify counter validation ci: ignore non Harvest error messages ci: enable debug log on Grafana * ci: simplify counter validation ci: ignore non Harvest error messages ci: enable debug log on Grafana ci: improve Grafana logging * ci: simplify counter validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: ignore non Harvest error messages