feat: Harvest should collect QOS policy groups #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
previously approved these changes
Mar 21, 2023
Hardikl
previously approved these changes
Mar 21, 2023
Comment on lines
+48
to
+51
| instance.SetLabel("min_throughput_iops", min.IOPS) | ||
| instance.SetLabel("max_throughput_iops", max.IOPS) | ||
| instance.SetLabel("min_throughput_mbps", min.Mbps) | ||
| instance.SetLabel("max_throughput_mbps", max.Mbps) |
There was a problem hiding this comment.
Should the label be absent/empty instead of having 0 values. For example if qos policy is 19.07MB/s-4.55TB/s then both min_throughput_iops and max_throughput_iops should not be published for that qos policy.
conf/zapi/default.yaml
Outdated
| @@ -14,6 +14,7 @@ objects: | |||
| # NetPort: netPort.yaml | |||
| Node: node.yaml | |||
| NtpServer: ntpserver.yaml | |||
| QosPolicy: qos_policy.yaml | |||
There was a problem hiding this comment.
should be qos_policy_fixed.yaml
There was a problem hiding this comment.
I think name qos_policy is better. We can differentiate between adapative and non-adaptive with a label in exported metrics? Avoids different names?
rahulguptajss
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.