feat: support aggr filter for flexgroup volumes #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrinds
reviewed
Feb 6, 2023
cgrinds
approved these changes
Feb 7, 2023
| } | ||
| // make sure the order of aggregate is same for each poll | ||
| sort.Strings(aggrs) | ||
| fg.SetLabel("aggr", strings.Join(aggrs, ",")) |
There was a problem hiding this comment.
It is better not to change aggr label returned by perf template given volume_labels will have empty aggr for flexgroup.
| @@ -31,28 +32,54 @@ func (me *Volume) Run(data *matrix.Matrix) ([]*matrix.Matrix, error) { | |||
| opsKeyPrefix := "temp_" | |||
| re := regexp.MustCompile(`^(.*)__(\d{4})$`) | |||
|
|
|||
| metricName := "aggrs" | |||
There was a problem hiding this comment.
may be 'volume_aggr_labels' is better output. Also rather than adding metric to the template perf matrix, it is better to create a new matrix for these labels so that existing aggr labels are not modified for perf template.
| cache := data.Clone(false, true, false) | ||
| cache.UUID += ".Volume" | ||
|
|
||
| me.Logger.Trace().Msgf("added metric: (%s) [%s] %v", metricName, metricName, metric) | ||
|
|
||
| flexgroupAggrsMap := make(map[string]map[string]bool) |
There was a problem hiding this comment.
can use the eisting custom DS set in harvest. It will save some of the checks.
There was a problem hiding this comment.
done, made the change in other PR: #1695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI panels:
This panel has 2 info to be shown, second info is from ontap.
new metric from zapiperf:
metric labels for flexgroup:
