Infinite sleep without needing a TTY or side effects #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the means by which the container keeps itself alive from running a `sh` process, to an explicit infinite sleep. Using a shell means the container does not continue to run after poller startup if run in detached mode, since stdin is closed the shell process immediately exits. When run in attached mode, use of shell will interpret any stdin as commands to be run within the container, which is potentially dangerous, and certainly unexpected. Fixes NetApp#164
|
Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @optiz0r on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. |
|
done as part of #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinite sleep without needing a TTY or side effects
This commit changes the means by which the container keeps itself
alive from running a
shprocess, to an explicit infinite sleep.Using a shell means the container does not continue to run after
poller startup if run in detached mode, since stdin is closed the
shell process immediately exits. When run in attached mode,
use of shell will interpret any stdin as commands to be run within
the container, which is potentially dangerous, and certainly unexpected.
Fixes #164