Pass through all container arguments exactly as specified #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the entrypoint wrapper took exactly two arguments, and passed them along unquoted, to harvest meaning any spaces made the given arguments split into additional passed arguments. This is confusing, because there's no way to know without reading the entrypoint code why that's happening, and it's unlike any other software out there. Any additional arguments given to the entrypoint were _silently_ ignored. This commit changes the entrypoint to pass _all_ arguments through unmodified. This is more intuitive and consistent with other applications, including the harvest application itself. *Compatibility break* Where users have previously customised container arguments as: ``` 'start' '--config /opt/harvest.yml ...' ``` These instead need to be passed as: ``` 'start' '--config' '/opt/harvest.yml' ... ``` Fixes NetApp#163
|
Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @optiz0r on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request. |
|
done as part of #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the entrypoint wrapper took exactly two arguments, and passed them along
unquoted, to harvest meaning any spaces made the given arguments split into additional
passed arguments. This is confusing, because there's no way to know without reading
the entrypoint code why that's happening, and it's unlike any other software out
there. Any additional arguments given to the entrypoint were silently ignored.
This commit changes the entrypoint to pass all arguments through unmodified.
This is more intuitive and consistent with other applications, including the
harvest application itself.
Compatibility break
Where users have previously customised container arguments as:
These instead need to be passed as:
Fixes #163