Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle batching in shelf plugin #1429

Merged
merged 14 commits into from
Nov 14, 2022
Merged

fix: handle batching in shelf plugin #1429

merged 14 commits into from
Nov 14, 2022

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Nov 8, 2022

No description provided.

cmd/collectors/zapi/plugins/shelf/shelf.go Outdated Show resolved Hide resolved
cmd/collectors/zapi/plugins/shelf/shelf.go Outdated Show resolved Hide resolved
Hardikl and others added 4 commits November 10, 2022 15:23
* feat: handle ZAPI batching with closure

* feat: handle ZAPI batching with closure

* feat: handle ZAPI batching with closure
feat: Add LogSet support to plugins
Copy link
Contributor

@rahulguptajss rahulguptajss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hardikl Could you check this PR after Chris code merge in it.

cgrinds
cgrinds previously approved these changes Nov 14, 2022
@cgrinds cgrinds merged commit 44549cd into main Nov 14, 2022
@cgrinds cgrinds deleted the batching branch November 14, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvokeRequestString method should only be used for cluster scoped zapi request
3 participants