feat: add StorageGrid collector and dashboard #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! |
cgrinds
force-pushed
the
cbg-storagegrid
branch
from
0024ff8 to
f45794c
Compare
Hardikl
previously approved these changes
Oct 3, 2022
- use tenant id instead of name to discriminate tenants - include region column in buckets panel
cgrinds
force-pushed
the
cbg-storagegrid
branch
from
57d5ce3 to
437e47f
Compare
rahulguptajss
approved these changes
Oct 10, 2022
Hardikl
reviewed
Oct 12, 2022
| apiVersion := s.Params.GetChildContentS("api") | ||
| if !strings.HasSuffix(s.client.APIPath, apiVersion) { | ||
| cur := s.client.APIPath | ||
| s.client.APIPath = "/apiVersion/" + apiVersion |
There was a problem hiding this comment.
"/apiVersion/" word would be required in endpoint ?
| func (s *StorageGrid) initClient() error { | ||
| var err error | ||
|
|
||
| if s.client, err = srest.NewClient(s.Options.Poller, s.Params.GetChildContentS("client_timeout")); err != nil { |
There was a problem hiding this comment.
same apply here: client_timeout gets loaded later in loadTemplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.