fix: skipped bookend ems whose key is node-name #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration/test/alert/alert.go
Outdated
| addr, user, pass := GetPollerDetail() | ||
| url := "https://" + addr + "/api/private/cli/event/generate" | ||
| method := "POST" | ||
| node_name := "umeng-aff300-06" |
There was a problem hiding this comment.
hard coding node_name doesn't seem correct. If node name in CI changes then would this test case fail?
There was a problem hiding this comment.
we have hardcoded cluster on which we do ems testing here. If the cluster would change in CI then yes, node also need to change.
May be I can move node name in GetPollerDetail function, where addr, user, pass exist. So, all changes would be required in one place when cluster upgrade/change in CI.
There was a problem hiding this comment.
moved node-name to GetPollerDetail func.
cgrinds
approved these changes
Aug 31, 2022
rahulguptajss
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of 14 bookend ems, 3 ems are node-scoped. So, when we do POST call of issuing ems and/or resolving ems we are not sure that given ems will be raised by ONTAP as due to node level.