docs: REST strategy doc #1234
Merged
docs: REST strategy doc #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignore the lint errors, those are fixed in a separate PR and caused by golang-lint pulling latest |
docs/architecture/rest-strategy.md
Outdated
| That means Harvest's `RestPerf` collector won't work until `9.11.1`. | ||
| ONTAP supports a subset of performance counters in `9.11.1`. The full set is available in `9.12.1`. | ||
|
|
||
| 2. It's better to publish a set of metrics once instead of multiple times. In other words, don't enable |
There was a problem hiding this comment.
This sentence may mean, don't use Rest before 9.13.1 even if you want to take advantage of new Rest specific configs. It should add more info about disabling duplicate counters to avoid duplicate metrics. Or this is better covered under FAQ below Can I use the REST and ZAPI collectors at the same time?
There was a problem hiding this comment.
I think it's clear. The FAQ answer says, "Yes, with caveats" and paragraph #2 describes one of the caveats. Does the next comment make it clearer?
rahulguptajss
approved these changes
Aug 29, 2022
Hardikl
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9.11.1fromrestperf/9.12.0torestperf/9.11.0. Not required, but more clear