feat: Network Port templates #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
approved these changes
Aug 24, 2022
cgrinds
reviewed
Aug 26, 2022
| @@ -443,7 +449,9 @@ func (r *Rest) HandleResults(result []gjson.Result, prop *prop, allowInstanceCre | |||
| } | |||
| count++ | |||
| } else { | |||
| r.Logger.Warn().Str("Instance key", instanceKey).Str("label", label).Msg("Missing label value") | |||
| if !util.Contains(ignoreLabelMissingWarning, r.GetObject()) { | |||
There was a problem hiding this comment.
minor but a map would be better than a list. On the other hand, this list only has one item so meh.
Doesn't this change suppress all labels warnings for NetPort?
If so, doesn't that make it easy to miss a mistyped label?
Can the bigger problem be solved by explicitly specifying the labels instead of using include_all_labels: true?
There was a problem hiding this comment.
Yes, all label warnings for NetPort will be suppressed. include_all_labels: true is used in prometheus.go and not during the collector. A solution would be to parse schema and compare if label is mistyped. I'll open a story to track it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472