Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove rewrite_as_label from templates #1212

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: remove rewrite_as_label from templates #1212

merged 1 commit into from
Aug 18, 2022

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 18, 2022
Hardikl
Hardikl approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we haven't implemented this functionality ?

@rahulguptajss
Copy link
Contributor Author

It seems we haven't implemented this functionality ?

Yeah it's there in template but never used in code.

@cgrinds cgrinds merged commit 092bbe6 into main Aug 18, 2022
@cgrinds cgrinds deleted the rg2-zapiperf-template branch August 18, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulguptajss @cgrinds @Hardikl