fix: dashboard changes for light theme #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Covered
|
|
Atleast the first column should have the green sign? |
|
Also keeping cross sign before text changes the indentation of records without any sign |
Discussed in call, we are good with only ❌ in first column. |
Discussed in call, we will go ahead with this indentation for now and based on the customer's feedback, we will revisit this. |
rahulguptajss
approved these changes
Jul 11, 2022
|
nice job @Hardikl |
cgrinds
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliance dashboard
Before changes:
After changes:
Security dashboard
before changes:
after changes:
