Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictable Harvest Plugin Ordering #736

Closed
2 tasks done
rahulguptajss opened this issue Dec 9, 2021 · 1 comment · Fixed by #750
Closed
2 tasks done

Predictable Harvest Plugin Ordering #736

rahulguptajss opened this issue Dec 9, 2021 · 1 comment · Fixed by #750
Labels
feature New feature or request status/done

Comments

@rahulguptajss
Copy link
Contributor

rahulguptajss commented Dec 9, 2021 •
edited
Loading

  • Plugins in templates should be ordered in their execution order
  • Plugins should chain their response based on output of previous plugin
@rahulguptajss rahulguptajss added the feature New feature or request label Dec 9, 2021
@rahulguptajss rahulguptajss self-assigned this Dec 9, 2021
rahulguptajss added a commit that referenced this issue Dec 15, 2021
@rahulguptajss
feat: plugin ordering
d75b64c 
Fixes #736
@rahulguptajss rahulguptajss mentioned this issue Dec 15, 2021
Merged
rahulguptajss added a commit that referenced this issue Dec 15, 2021
@rahulguptajss
feat: remove commented code
130e062 
Fixes #736
rahulguptajss added a commit that referenced this issue Dec 15, 2021
@rahulguptajss
feat: remove fmt
3de296c 
Fixes #736
rahulguptajss added a commit that referenced this issue Dec 16, 2021
@rahulguptajss
feat: unit tests and review comments addressed
bc4acc5 
Fixes #736
rahulguptajss added a commit that referenced this issue Dec 17, 2021
@rahulguptajss
feat: plugin ordering (#750)
fcdf8c0 
* feat: plugin ordering

Fixes #736

* feat: remove commented code

Fixes #736

* feat: remove fmt

Fixes #736

* feat: unit tests and review comments addressed

Fixes #736
@rahulguptajss
Copy link
Contributor Author

Tested in release/22.02. Plugins works in chain as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: plugin ordering NetApp/harvest
1 participant
@rahulguptajss