Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in /opt/harvest/conf/zapiperf/cdot/9.8.0/volume.yaml file was overwritten during harvest upgrade #309

Closed
madhusudhanarya opened this issue Jul 15, 2021 · 5 comments

Comments

@madhusudhanarya
Copy link

Describe the bug
We have made few custom changes to /opt/harvest/conf/zapiperf/cdot/9.8.0/volume.yaml file. During harvest upgrade, this changes have been overwriiten.

Harvest version: harvest version 21.05.3-2 (commit b482aff) (build date 2021-06-28T21:08:05+0530) linux/amd64
Command line arguments used: harvest start clus01
OS: CentOS Linux release 7.9.2009 (Core)
Install method: YUM
ONTAP Version: 9.8P4

To Reproduce
Make some changes to volume.yaml file and run harvest update

Expected behavior
Config files should not be overwritten during the upgrade.

Actual behavior
Custom changes made to the volume.yaml file was overwritten

Possible solution, workaround, fix
Make a copy of the production file and diff it against the default one in the RPM. If there are any changes, copy the production file to another location and ask customer to check and copy back his file to required path

@madhusudhanarya madhusudhanarya changed the title custom changes to volume.yaml file in zapi is overridden post harvest upgrade Changes in /opt/harvest/conf/zapiperf/cdot/9.8.0/volume.yaml file was overwritten during harvest upgrade Jul 15, 2021
@cgrinds
Copy link
Collaborator

cgrinds commented Jul 15, 2021

hi @madhusudhanarya we added sub-templates for customer edits. Does this line of documentation address your issue?

@madhusudhanarya
Copy link
Author

Hi @cgrinds: we need to implement below feature.

#209

can you suggest how i can do this using sub-templates?

@cgrinds
Copy link
Collaborator

cgrinds commented Jul 19, 2021

@madhusudhanarya - it's not completely possible until #124 is finished. You can get close with the following

cp conf/zapi/cdot/9.8.0/volume.yaml conf/zapi/cdot/9.8.0/tagvolume.yaml
  • Create a conf/zapi/custom.yaml and copy/paste the following into it to use the new template
collector:          Zapi

# Order here matters!
schedule:
  - instance: 600s
  - data: 180s

objects:
  Volume:           tagvolume.yaml

Bounce harvest and you will see the tagged volumes

@madhusudhanarya
Copy link
Author

Thank you @cgrinds. Was able to get custom labels working after following above instructions. We can close this issue.

@cgrinds
Copy link
Collaborator

cgrinds commented Jul 20, 2021

awesome - glad you got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants