Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poller ignores config when called directly #28

Closed
cgrinds opened this issue May 20, 2021 · 0 comments · Fixed by #29
Closed

Poller ignores config when called directly #28

cgrinds opened this issue May 20, 2021 · 0 comments · Fixed by #29

Comments

@cgrinds
Copy link
Collaborator

cgrinds commented May 20, 2021 

go run cmd/poller/poller.go --config /x/y/z/foo.yml -p unix

incorrectly uses options config: harvest.yml
cgrinds added a commit that referenced this issue May 20, 2021
@cgrinds
Don't overwrite cobra initialized config
abd1517 
Fixes #28
@cgrinds cgrinds mentioned this issue May 20, 2021
Merged
cgrinds added a commit that referenced this issue May 21, 2021
@cgrinds
Add test to ensure config path is not overwritten
28d4fba 
This test is in response to issue #28.

Reverted the [fix](abd1517) and verified the test fails with the following output.

```
 --- FAIL: TestConfigPath (0.00s)
    options_test.go:13: options.Config expected=["foo"], actual was=["harvest.yml"]
```

Apply the fix and test passes.
@cgrinds cgrinds mentioned this issue May 21, 2021
Merged
cgrinds added a commit that referenced this issue May 21, 2021
@cgrinds
Add test to ensure config path is not overwritten
589d1b5 
This test is in response to issue #28.

Reverted the [fix](abd1517) and verified the test fails with the following output.

```
 --- FAIL: TestConfigPath (0.00s)
    options_test.go:13: options.Config expected=["foo"], actual was=["harvest.yml"]
```

Apply the fix and test passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't overwrite cobra initialized config NetApp/harvest
1 participant
@cgrinds