Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if the RestPerf collector can eliminate PollInstance #2421

Closed
cgrinds opened this issue Oct 11, 2023 · 1 comment · Fixed by #3207
Closed

Investigate if the RestPerf collector can eliminate PollInstance #2421

cgrinds opened this issue Oct 11, 2023 · 1 comment · Fixed by #3207
Labels
24.11 feature New feature or request status/done

Comments

@cgrinds
Copy link
Collaborator

cgrinds commented Oct 11, 2023 •
edited
Loading

ZapiPerf requires PollInstance because perf-object-get-instances (called by PollData) requires the list of instances you want to collect counters for.

RestPerf does not require that so we may be able to eliminate PollInstance.
@cgrinds cgrinds added feature New feature or request 24.02 labels Oct 11, 2023
@rahulguptajss rahulguptajss self-assigned this Dec 4, 2023
@rahulguptajss rahulguptajss removed their assignment Dec 13, 2023
@cgrinds cgrinds removed the 24.02 label Jan 23, 2024
@rahulguptajss rahulguptajss self-assigned this Jun 18, 2024
@rahulguptajss rahulguptajss removed their assignment Jul 3, 2024
cgrinds added a commit that referenced this issue Oct 11, 2024
@cgrinds
perf: RestPerf collectors should only run PollInstance for workloads
dcc5d66 
Fixes: #2421
@cgrinds cgrinds mentioned this issue Oct 11, 2024
Merged
cgrinds added a commit that referenced this issue Oct 14, 2024
@cgrinds
perf: RestPerf collectors should only run PollInstance for workloads
99ae8bf 
Fixes: #2421
@cgrinds
Copy link
Collaborator Author

cgrinds commented Nov 4, 2024

Verified in 24.11 ddb97c5

rg ' instance:' conf/restperf/
conf/restperf/9.12.0/workload_volume.yaml
13:  - instance: 10m

conf/restperf/9.12.0/workload_detail.yaml
12:  - instance: 10m

conf/restperf/9.12.0/workload_detail_volume.yaml
11:  - instance: 10m

conf/restperf/9.12.0/workload.yaml
11:  - instance: 10m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
24.11 feature New feature or request status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: RestPerf collectors should only run PollInstance for workloads NetApp/harvest
2 participants
@cgrinds @rahulguptajss