Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUN info does not get collected #230

Closed
hashi825 opened this issue Jun 24, 2021 · 5 comments · Fixed by #231
Closed

LUN info does not get collected #230

hashi825 opened this issue Jun 24, 2021 · 5 comments · Fixed by #231
Labels
bug Something isn't working status/done

Comments

@hashi825
Copy link

Describe the bug
Pollers constantly report lag behind schedule for small delays

Environment
Provide accurate information about the environment to help us reproduce the issue.

  • Harvest version: harvest version 21.05.2-1 (commit ce091de) (build date 2021-06-14T20:31:09+0530) linux/amd64
  • Command line arguments used: [e.g. bin/harvest start --config=foo.yml --collectors Zapi]
  • OS: RHEL 7.9
  • Install method: yum
  • ONTAP Version: 9.7
  • Other:

To Reproduce
N/A

Expected behavior
Collect LUN Zapi info such as size used, node, status etc

Actual behavior
No information gets collected

Possible solution, workaround, fix
Related to

node-details-info:

Correct counter is lun-info and not node-details-info, changing this fixes data collection

cgrinds added a commit that referenced this issue Jun 24, 2021
@cgrinds cgrinds self-assigned this Jun 24, 2021
@cgrinds cgrinds added bug Something isn't working and removed status/needs-triage labels Jun 24, 2021
@cgrinds
Copy link
Collaborator

cgrinds commented Jun 24, 2021

Good catch @hashi825 thanks!

@cgrinds
Copy link
Collaborator

cgrinds commented Jun 24, 2021

Question for you @hashi825 - Can you check and make sure you're getting the correct name

I also had to change

split: path `:` ,,,lun

to
split: path '/' ,,,lun

Before lun is blank

lun_size{datacenter="DC-01",cluster="sim-0001",node="",qtree="",lun="",volume="vol-460",svm="vserver-39"} 42949672960

After lun is correct

lun_size_used{cluster="sim-0001",datacenter="DC-01",node="",qtree="",lun="lun-490",volume="vol-460",svm="vserver-39"} 42949672960

Looks like node and qtree need fixing too.

cgrinds added a commit that referenced this issue Jun 24, 2021
@hashi825
Copy link
Author

You're right, I changed the split and now get the lun name, I'm getting the correct node label though. Can't comment on qtrees since I don't have them in my environment.

@cgrinds
Copy link
Collaborator

cgrinds commented Jun 24, 2021

Excellent - updated the PR with the path fix and good to hear node label is correct for you. That's likely an issue on my end.

cgrinds added a commit that referenced this issue Jun 25, 2021
@rajeshl8
Copy link

Verified the issue and the fix works with out any issues.Observed lun name and size details are displayed correctly.
root@scspa2380901007:/opt/harvest# /opt/harvest/bin/harvest -v
harvest version 21.05.3-4 (commit c2dafee) (build date 2021-06-25T23:20:41+0530) linux/amd64

root@scspa2380901007:/opt/harvest# curl -s 'http://127.0.0.1:12991/metrics' | grep lun
lun_labels{datacenter="F2240-127-26",cluster="F2240-127-26_28",node="F2240-127-28",qtree="",lun="ds",volume="NSLM_VOL_LUN_1551009070672",svm="COCA",state="online"} 1.0
lun_size{datacenter="F2240-127-26",cluster="F2240-127-26_28",node="F2240-127-28",qtree="",lun="ds",volume="NSLM_VOL_LUN_1551009070672",svm="COCA"} 1077511680
lun_size_used{datacenter="F2240-127-26",cluster="F2240-127-26_28",node="F2240-127-28",qtree="",lun="ds",volume="NSLM_VOL_LUN_1551009070672",svm="COCA"} 0

@cgrinds cgrinds removed their assignment May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants