Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter: duplicate labels #132

Closed
vgratian opened this issue Jun 8, 2021 · 2 comments
Closed

Prometheus exporter: duplicate labels #132

vgratian opened this issue Jun 8, 2021 · 2 comments
Assignees
@vgratian
Labels
bug Something isn't working status/done

Comments

@vgratian
Copy link
Contributor

vgratian commented Jun 8, 2021

Describe the bug
This was reported by a customer: some metrics have duplicate labels (e.g. aggr_disk_user_read_latency{datacenter="xxx",cluster="xxx",node="xxx",node="",aggr="xxx"}
@vgratian
Copy link
Contributor Author

vgratian commented Jun 8, 2021

I was not able to reproduce this issue

@vgratian vgratian mentioned this issue Jun 8, 2021
Closed
@vgratian
Copy link
Contributor Author

I was able to reproduce: duplicate labels happen in the ZapiPerf collector when the same label is added under both global_labels and instance_keys. Will fix this in this branch.

@vgratian vgratian self-assigned this Jun 16, 2021
@vgratian vgratian mentioned this issue Jun 18, 2021
Merged
@vgratian vgratian added bug Something isn't working status/testme and removed status/open labels Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgratian vgratian

Labels
bug Something isn't working status/done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vgratian @ruanruijuan