Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: incomplete metatags #104

Closed
vgratian opened this issue Jun 2, 2021 · 2 comments · Fixed by #131
Closed

Prometheus exporter: incomplete metatags #104

vgratian opened this issue Jun 2, 2021 · 2 comments · Fixed by #131
Assignees
Labels
bug Something isn't working status/done

Comments

@vgratian
Copy link
Contributor

vgratian commented Jun 2, 2021

Describe the bug

  • instance labels (when exported as separate metric) and status metrics do not get the "HELP" and "TYPE" metatags

This was reported by a customer, I will add more details when I get them from the customer and/or reproduce the issues myself.

@vgratian vgratian added bug Something isn't working status/needs-triage and removed status/needs-triage labels Jun 2, 2021
@vgratian vgratian changed the title Prometheus exporter: incomplete metatags & duplicate labels Prometheus exporter: incomplete metatags Jun 8, 2021
@vgratian
Copy link
Contributor Author

vgratian commented Jun 8, 2021

I moved the second issue to #132

@cgrinds
Copy link
Collaborator

cgrinds commented Jun 11, 2021

Here's how I validated.

Exporters:
    prometheus2:
        exporter: Prometheus
        port: 12991
        local_http_addr: 0.0.0.0
        add_meta_tags: true
Pollers:
    ocum-mobility-01-02:
        datacenter: nane
        addr: -REDACTED-
        auth_style: password
        username: -REDACTED-
        password: -REDACTED-
        use_insecure_tls: true
        collectors:
            - Zapi
            - ZapiPerf
        exporters:
            - prometheus2

Restarted that poller, waited a minute.
Executed curl -s localhost:12990/metrics | grep "#" | grep Pseudo

# HELP snapmirror_labels Pseudo-metric for snapmirror labels
# HELP aggr_labels Pseudo-metric for aggr labels
# HELP node_labels Pseudo-metric for node labels
# HELP nic_labels Pseudo-metric for nic labels
# HELP shelf_labels Pseudo-metric for shelf labels
# HELP disk_labels Pseudo-metric for disk labels
# HELP volume_labels Pseudo-metric for volume labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants