refactor: remove uses of nolint:gocritic (#3299)

NetApp · Nov 18, 2024 · ae1af95 · ae1af95
1 parent 1135ee5
commit ae1af95
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/collectors/rest/plugins/volumeanalytics/volumeanalytics.go b/cmd/collectors/rest/plugins/volumeanalytics/volumeanalytics.go
@@ -230,7 +230,7 @@ func (v *VolumeAnalytics) Run(dataMap map[string]*matrix.Matrix) ([]*matrix.Matr
 					}
 				}
 
-				if len(atBytesUsedValues) == len(atBytesUsedPercentages) && len(atBytesUsedValues) == len(atBytesUsedLabels) { //nolint:gocritic
+				if len(atBytesUsedValues) == len(atBytesUsedPercentages) && len(atBytesUsedPercentages) == len(atBytesUsedLabels) {
 
 					for i, av := range atBytesUsedValues {
 						if av == "" {

diff --git a/cmd/harvest/harvest.go b/cmd/harvest/harvest.go
@@ -464,8 +464,7 @@ func startPoller(pollerName string, promPort int, opts *options) {
 	// Start the poller process in the background
 	if err := cmd.Start(); err != nil {
 		fmt.Println(err)
-		closeDevNull(devNull) // os.Exit means closeDevNull will not run so call directly
-		os.Exit(1)            //nolint:gocritic
+		defer os.Exit(1)
 	}
 }