feat: update ONTAP metric document

Fixes #2008

cmd/tools/generate/counter.go

@@ -43,6 +43,21 @@ var (
 		"read_latency_hist":       {},
 		"write_latency_hist":      {},
 	}
+	// Excludes these Rest gaps from logs
+	excludeLogRestCounters = []string{
+		"smb2_",
+		"ontaps3_svm_",
+		"nvmf_rdma_port_",
+		"nvmf_tcp_port_",
+		"netstat_",
+		"external_service_op_",
+		"fabricpool_average_latency",
+		"fabricpool_get_throughput_bytes",
+		"fabricpool_put_throughput_bytes",
+		"fabricpool_stats",
+		"fabricpool_throughput_ops",
+		"iw_",
+	}
 )
 
 type Counters struct {
@@ -509,8 +524,17 @@ func generateCounterTemplate(counters map[string]Counter, client *rest.Client) {
 		// Print such counters which are missing Rest mapping
 		if len(counter.APIs) == 1 {
 			if counter.APIs[0].API == "ZAPI" {
+				isPrint := true
+				for _, substring := range excludeLogRestCounters {
+					if strings.HasPrefix(counter.Name, substring) {
+						isPrint = false
+						break
+					}
+				}
 				//missing Rest Mapping
-				fmt.Printf("Missing %s mapping for %v \n", "REST", counter)
+				if isPrint {
+					fmt.Printf("Missing %s mapping for %v \n", "REST", counter)
+				}
 			}
 		}
 

cmd/tools/generate/counter.yaml

@@ -241,6 +241,18 @@ counters:
         ONTAPCounter: Harvest generated
         Template: conf/zapi/cdot/9.8.0/sensor.yaml
 
+  - Name: fabricpool_average_latency
+    Description: This counter is deprecated.Average latencies executed during various phases of command execution. The execution-start latency represents the average time taken to start executing a operation. The request-prepare latency represent the average time taken to prepare the commplete request that needs to be sent to the server. The send latency represents the average time taken to send requests to the server. The execution-start-to-send-complete represents the average time taken to send a operation out since its execution started. The execution-start-to-first-byte-received represent the average time taken to to receive the first byte of a response since the command's request execution started. These counters can be used to identify performance bottlenecks within the object store client module.
+
+  - Name: fabricpool_get_throughput_bytes
+    Description: This counter is deprecated. Counter that indicates the throughput for GET command in bytes per second.
+
+  - Name: fabricpool_put_throughput_bytes
+    Description: This counter is deprecated. Counter that indicates the throughput for PUT command in bytes per second.
+
+  - Name: fabricpool_stats
+    Description: This counter is deprecated. Counter that indicates the number of object store operations sent, and their success and failure counts. The objstore_client_op_name array indicate the operation name such as PUT, GET, etc. The objstore_client_op_stats_name array contain the total number of operations, their success and failure counter for each operation.
+
   - Name: metadata_collector_api_time
     Description: amount of time to collect data from monitored cluster object
     APIs:

conf/zapiperf/cdot/9.8.0/fcvi.yaml

@@ -6,7 +6,7 @@ object:                   fcvi
 instance_key:             uuid
 
 counters:
-  - fw_SyStatDiscardFrames  => firmwares_systat_discard_frames
+  - fw_SyStatDiscardFrames  => firmware_systat_discard_frames
   - fw_invalid_crc          => firmware_invalid_crc_count
   - fw_invalid_xmit_words   => firmware_invalid_transmit_word_count
   - fw_link_failure         => firmware_link_failure_count