Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): 完善innerHTML实现 #8837 #8838

Closed
wants to merge 0 commits into from
Closed

feat(runtime): 完善innerHTML实现 #8837 #8838

wants to merge 0 commits into from

Conversation

ywmail
Copy link
Contributor

@ywmail ywmail commented Mar 8, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
修复HTML Element不支持获取innerHTML的问题。#8837

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id HTML Element不支持获取innerHTML #8837
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@ywmail ywmail force-pushed the next branch 3 times, most recently from 791a228 to f1f0816 Compare March 8, 2021 10:25
@Chen-jj
Copy link
Contributor

Chen-jj commented Mar 10, 2021

@ywmail 麻烦提供一下详细的测试用例～

@Chen-jj Chen-jj linked an issue Mar 10, 2021 that may be closed by this pull request
HTML Element不支持获取innerHTML #8837
Open
@ywmail
Copy link
Contributor Author

ywmail commented Mar 11, 2021

@ywmail 麻烦提供一下详细的测试用例～

嗯，晚些时候补一下测试用例。

@luckyadam
Copy link
Member

@ywmail 麻烦提供一下详细的测试用例～

嗯，晚些时候补一下测试用例。

hello，可以补上测试用例么

@ywmail
Copy link
Contributor Author

ywmail commented May 27, 2021

hello，可以补上测试用例么

好的，最近忙别的去了，下周补上。

@taro-bot2 taro-bot2 bot mentioned this pull request May 29, 2021
Closed
@Chen-jj Chen-jj added question Further information is requested V-3 Version - 3.x labels Jul 7, 2021
@yoyo837
Copy link
Contributor

yoyo837 commented Nov 10, 2022

@ywmail ping

@ywmail ywmail closed this Nov 11, 2022
@ywmail
Copy link
Contributor Author

ywmail commented Nov 11, 2022

不好意思，代码还不完善，没有处理一些标签独有的属性，我尝试完善下。

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 11, 2022

欢迎重新PR

@ywmail
Copy link
Contributor Author

ywmail commented Nov 11, 2022

欢迎重新PR

嗯嗯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML Element不支持获取innerHTML
4 participants
@ywmail @Chen-jj @luckyadam @yoyo837