Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 同步ReactNative与微信的网络请求参数 #5752

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix: 同步ReactNative与微信的网络请求参数 #5752

merged 1 commit into from
Mar 23, 2020

Conversation

davistsin
Copy link

这个 PR 做了什么? (简要描述所做更改)

此PR用于修复同步ReactNative与微信的网络请求参数,例如有下面一段代码:

  return new Promise((resolve) => {
    const complete = (result) => {
      const networkErrorCode = 600
      formatResult = {
        ...handleData(result.data || {}, result.statusCode || networkErrorCode),
        header: result.header || {},
        status: result.statusCode || networkErrorCode
      }
      handleTips(tips, formatResult)
      if (formatResult.code !== 0) {
        errorReport.api({ code: formatResult.code, msg: formatResult.msg, url: newUrl, params: data })
      }
      resolve(formatResult)
    }
    // @ts-ignore
    Taro.request({ ...opt, complete })
  })

此种写法在微信、支付宝小程序可以正常运行,但是无法在ReactNative上正常运行,原因是ReactNative没有接收complete等参数。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@Pines-Cheng
Copy link
Contributor

非常棒~

@Pines-Cheng Pines-Cheng merged commit 9217381 into NervJS:2.x Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants