Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillUnmount lifecycle #5135

Merged
merged 3 commits into from
Dec 23, 2019
Merged

componentWillUnmount lifecycle #5135

merged 3 commits into from
Dec 23, 2019

Conversation

li2go
Copy link

@li2go li2go commented Dec 19, 2019 •
edited
Loading

rename componentWillUnMount to componentWillUnmount

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

li2go and others added 3 commits December 19, 2019 18:20
@li2go
componentWillUnmount lifecycle
1d10ee5 
rename `componentWillUnMount` to `componentWillUnmount`
@li2go
fix: rename lifecircle method componentWillUnMount to `componentWil…
7dbb59c 
…lUnmount`
@li2go
Merge branch '2.x' into patch-1
16fa5b7 
* 2.x:
  fix: rename lifecircle method `componentWillUnMount` to `componentWillUnmount`
@Garfield550 Garfield550 requested review from Chen-jj and Littly and removed request for Chen-jj December 19, 2019 13:55
@Garfield550 Garfield550 added the H5 label Dec 19, 2019
@taro-bot taro-bot bot mentioned this pull request Dec 21, 2019
Closed
@luckyadam luckyadam merged commit 951e34d into NervJS:2.x Dec 23, 2019
luckyadam pushed a commit that referenced this pull request Dec 24, 2019
@li2go @luckyadam
fix(components): componentWillUnmount lifecycle (#5135)
297eefa 
* componentWillUnmount lifecycle

rename `componentWillUnMount` to `componentWillUnmount`

* fix: rename lifecircle method `componentWillUnMount` to `componentWillUnmount`
@taro-bot taro-bot bot mentioned this pull request Dec 28, 2019
Closed
jiangzm pushed a commit to jiangzm/taro that referenced this pull request Dec 7, 2020
@li2go @jiangzm
fix(components): componentWillUnmount lifecycle (NervJS#5135)
6a36dfa 
* componentWillUnmount lifecycle

rename `componentWillUnMount` to `componentWillUnmount`

* fix: rename lifecircle method `componentWillUnMount` to `componentWillUnmount`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Littly Littly Awaiting requested review from Littly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@li2go @luckyadam @Garfield550