fix issue 4203,加入缓存机制，转换时间从半个小时优化至8分钟内 #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
牛逼牛逼！ |
yuche
requested changes
Aug 26, 2019
packages/taroize/src/cache.ts
Outdated
| } | ||
|
|
||
| export function saveCacheWxml(dirpath: string, wxml: Wxml) { | ||
| if (!dirpath) { |
packages/taroize/src/cache.ts
Outdated
| @@ -0,0 +1,14 @@ | |||
| import { Wxml } from './wxml' | |||
| import { cloneDeep } from 'lodash' | |||
| const cacheMap = new Map() | |||
packages/taroize/src/wxml.ts
Outdated
| refIds: Set<string> | ||
| } { | ||
| export function parseWXML (dirPath: string, wxml?: string, parseImport?: boolean): Wxml { | ||
| let parseResult: Wxml = getCacheWxml(dirPath) |
There was a problem hiding this comment.
getCacheWxml 可能会返回 undefined，那这个签名应该就是不对的。如果不会，下一个判断也就没必要了。
There was a problem hiding this comment.
getCacheWxml是可能返回undefined
yuche
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
#4203
这个 PR 是什么类型? (至少选择一个)
错误修复(Bugfix) issue id #4203
新功能(Feature)
代码重构(Refactor)
TypeScript 类型定义修改(Typings)
文档修改(Docs)
代码风格更新(Code style update)
其他，请描述(Other, please describe):
这个 PR 满足以下需求:
提交到 master 分支
Commit 信息遵循 Angular Style Commit Message Conventions
所有测试用例已经通过
代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
在本地测试可用，不会影响到其它功能
这个 PR 涉及以下平台:
微信小程序
支付宝小程序
百度小程序
头条小程序
QQ 轻应用
快应用平台（QuickApp）
Web 平台（H5）
移动端（React-Native）
其它需要 Reviewer 或社区知晓的内容：