Skip to content

Commit

Permalink
refactor(eslint): ESLint 不再检查 .tsx 文件, close #1755
Browse files Browse the repository at this point in the history
  • Loading branch information
yuche committed Jan 2, 2019
1 parent fba22ea commit bf08d6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/taro-transformer-wx/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default function transform (options: Options): TransformResult {
plugins: [
require('babel-plugin-transform-flow-strip-types'),
[require('babel-plugin-transform-define').default, options.env]
].concat(process.env.ESLINT === 'false' || options.isNormal ? [] : eslintValidation).concat((process.env.NODE_ENV === 'test') ? [] : require('babel-plugin-remove-dead-code').default)
].concat(process.env.ESLINT === 'false' || options.isNormal || options.isTyped ? [] : eslintValidation).concat((process.env.NODE_ENV === 'test') ? [] : require('babel-plugin-remove-dead-code').default)
}).ast as t.File
if (options.isNormal) {
return { ast } as any
Expand Down

3 comments on commit bf08d6a

@mindfocus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不检查不好吧, types一点点在完善呢,不检查了还要types和typescript干啥

@yuche
Copy link
Contributor Author

@yuche yuche commented on bf08d6a Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 不检查,tsc 还是会检查的

@mindfocus
Copy link
Contributor

@mindfocus mindfocus commented on bf08d6a Jan 3, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.