Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable config flag to disable HA intents #625

Closed
wants to merge 1 commit into from

Conversation

mikejgray
Copy link
Contributor

Description

Flips the feature flag for disabling HA intent when HA isn't connected to "on."

Issues

mikejgray/neon-homeassistant-skill#38

Other Notes

Pairs with mikejgray/neon-homeassistant-skill#39, but won't do anything if this isn't available.

@mikejgray mikejgray requested a review from NeonDaniel March 3, 2024 04:54
@NeonDaniel
Copy link
Member

Will the current plugin automatically update this flag after HA setup is completed?

@mikejgray
Copy link
Contributor Author

Will the current plugin automatically update this flag after HA setup is completed?

It will not, but it doesn’t need to. This configures whether or not the feature is enabled

@NeonDaniel
Copy link
Member

The linked PR is for the skill, but the config change is for the PHAL plugin; is there a minimum PHAL plugin version that implements this, or should the setting be applied to the skill default settings?

@mikejgray
Copy link
Contributor Author

The linked PR is for the skill, but the config change is for the PHAL plugin; is there a minimum PHAL plugin version that implements this, or should the setting be applied to the skill default settings?

Good callout. The minimum PHAL plugin version will be the next one that's released after this PR is merged. However, I don't think it hurts anything if the extra config value is there, correct? It will simply be ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants