Fixes cache migration from 0.19 to 0.20

Resolves brave#10595 Auditors: Test Plan:
NejcZdovc · Jan 23, 2018 · 2e9f71c · 2e9f71c
1 parent a3b96a2
commit 2e9f71c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/app/sessionStore.js b/app/sessionStore.js
@@ -804,7 +804,10 @@ module.exports.runPreMigrations = (data) => {
     }
 
     // Add cache to the state
-    data.cache = {}
+    if (!data.cache) {
+      data.cache = {}
+    }
+
     data.cache.bookmarkLocation = data.locationSiteKeysCache
     data.cache.bookmarkOrder = sortBookmarkOrder(bookmarkOrder)
 

diff --git a/test/unit/app/sessionStoreTest.js b/test/unit/app/sessionStoreTest.js
@@ -1372,7 +1372,7 @@ describe('sessionStore unit tests', function () {
           '12': {}
         },
         cache: {
-          fakeEntry: {}
+          ledgerVideos: {}
         },
         history: {
           'https://not-a-real-entry|0': {}
@@ -1700,8 +1700,8 @@ describe('sessionStore unit tests', function () {
           it('creates an entry for bookmark order', function () {
             assert(newValue.bookmarkOrder)
           })
-          it('destroys any existing values in `data.cache`', function () {
-            assert.equal(newValue.fakeEntry, undefined)
+          it('keep any existing values in `data.cache`', function () {
+            assert(newValue.ledgerVideos)
           })
         })