Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-all): add commitizen + commitlint with scripts, config & dependencies #339

Merged

Conversation

tenretC
Copy link
Contributor

@tenretC tenretC commented Apr 26, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #290

What is the new behavior?

  • Add Commitizen and Commitlint to help us standardize out commit messages.
  • Add dependencies, scripts in package.json of the root
  • Add doc in CONTRIBUTING.md
  • Add configuration in root :
    .cz-config.js (config for customizable template for Commitizen)
    commitlint.config.js (config for Commitlint)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Apr 26, 2018

Pull Request Test Coverage Report for Build 232

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.558%

Totals Coverage Status
Change from base Build 229: 0.0%
Covered Lines: 7900
Relevant Lines: 8180

💛 - Coveralls

@christophercr christophercr merged commit d35ec9f into NationalBankBelgium:master Apr 26, 2018
@tenretC tenretC deleted the feature/commitizen branch April 26, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants