-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stark-ui): implement stark-date-time-picker
component
#1270
feat(stark-ui): implement stark-date-time-picker
component
#1270
Conversation
b62cd8b
to
7a40702
Compare
a73fa8e
to
190d281
Compare
@SuperITMan @cnomes I've updated this PR with the "finished" implementation of the DateTime picker. Can you have a look? There is still one small fix to do in the styling and also the unit tests need to be expanded, but in terms of functionality the feature is done 😉 (or I hope so). |
stark-date-time-picker
componentstark-date-time-picker
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of remarks:
- when you disable an empty picker the icons get shown again.
- on the example page if you have more than 1 error they overlap with the button below
- and the clear button moves everything around.
Also I think a nice feature would be that when you press tab when in the date input you focus the time input
showcase/src/app/demo-ui/pages/date-time-picker/demo-date-time-picker-page.component.ts
Outdated
Show resolved
Hide resolved
showcase/src/app/demo-ui/pages/date-time-picker/demo-date-time-picker-page.component.ts
Outdated
Show resolved
Hide resolved
I'm really liking how its working. 👍 |
091493b
to
d3ed804
Compare
@SuperITMan @cnomes I've updated the PR with all the styling fixes and unit tests. I also applied the changes based on your last remarks. However I have some concerns about the following remarks:
In fact this is the same behavior in the Material Date Picker, so I think we should keep it like that in order to be consistent.
I don't think this is a good idea in terms of UX because the user should be able to display the calendar also with the keyboard. So if we change the tabbing order, it will be confusing for the user. Can you guys review again this PR? |
@cnomes @SuperITMan can you guys have a look on this PR? I've done all the fixes mentioned in your remarks. This way we can release today or tomorrow the latest 😉 |
Still looks good to me. 👍Is the plan still to release today? |
Mmm, most likely tomorrow :p |
d3ed804
to
6075e6a
Compare
@SuperITMan I've updated this PR with the small fix that you mentioned: the time field can now be entirely cleared manually and type a different time ;) Can you have a look? |
CLOSES ISSUE: #587
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #587
What is the new behavior?
Implemented DateTimePicker module and component that integrates with Reactive Forms and Angular Material MatFormField control.
Does this PR introduce a breaking change?