Merge pull request diffblue#2425 from tautschnig/vs-virtual

Add missing virtual destructor
NathanJPhillips · Jul 8, 2018 · be7159a · be7159a
2 parents c6f9231 + 0c9658f
commit be7159a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/goto-instrument/rw_set.h b/src/goto-instrument/rw_set.h
@@ -40,7 +40,7 @@ class rw_set_baset
   {
   }
 
-  ~rw_set_baset() {}
+  virtual ~rw_set_baset() = default;
 
   struct entryt
   {
@@ -136,8 +136,6 @@ class _rw_set_loct:public rw_set_baset
   {
   }
 
-  ~_rw_set_loct() {}
-
 protected:
   value_setst &value_sets;
   const goto_programt::const_targett target;
@@ -192,8 +190,6 @@ class rw_set_loct:public _rw_set_loct
   {
     compute();
   }
-
-  ~rw_set_loct() {}
 };
 
 // another producer, this time for entire functions
@@ -213,8 +209,6 @@ class rw_set_functiont:public rw_set_baset
     compute_rec(function);
   }
 
-  ~rw_set_functiont() {}
-
 protected:
   const namespacet ns;
   value_setst &value_sets;
@@ -258,8 +252,6 @@ class rw_set_with_trackt:public _rw_set_loct
     compute();
   }
 
-  ~rw_set_with_trackt() {}
-
 protected:
   /* flag and variable in the expression, from which we dereference */
   bool dereferencing;

diff --git a/src/pointer-analysis/value_set.h b/src/pointer-analysis/value_set.h
@@ -45,6 +45,8 @@ class value_sett
   {
   }
 
+  virtual ~value_sett() = default;
+
   static bool field_sensitive(
     const irep_idt &id,
     const typet &type,

diff --git a/src/util/endianness_map.h b/src/util/endianness_map.h
@@ -41,6 +41,8 @@ class endianness_mapt
   {
   }
 
+  virtual ~endianness_mapt() = default;
+
   size_t map_bit(size_t bit) const
   {
     assert(bit<map.size());
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,6 +41,8 @@ class endianness_mapt @@
       {
       }
+      virtual ~endianness_mapt() = default;
       size_t map_bit(size_t bit) const
       {
         assert(bit<map.size());
@@ Expand Down @@