[FINNA-3169] Quria: Add proper check whether item is reservable #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Jan 31, 2025
| @@ -336,10 +341,11 @@ public function getHolding($id, array $patron = null, array $options = []) | |||
| * @param array $organisationHoldings Organisation holdings | |||
| * @param string $id The record id to retrieve the holdings | |||
| * @param array $journalInfo Jornal information | |||
| * @param string $reservable Is the record reservable | |||
There was a problem hiding this comment.
Pitäisi olla ?string (ja $journalInfon pitäisi olla ?array). Voisiko parametreilla olla muutenkin tyypit funktion määrittelyssä?
| $holdings, | ||
| $id, | ||
| null, | ||
| $response->$functionResult->catalogueRecordDetail->reservable ?? '' |
There was a problem hiding this comment.
Toimiiko tämä varmasti oikein ilman string-castausta?
There was a problem hiding this comment.
En ainakaan huomannut tilannetta missä ei toimisi, mutta laitoin castauksen varmuuden vuoksi nyt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quriasta saadaan tänään tulleen päivityksen myötä tarkempi tieto varattavuudesta