Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es): make nullable fields undefinable, dissociate Message and Operation #3548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodinsamuel
Copy link
Collaborator

Changes

Fixes https://linear.app/nango/issue/NAN-2738/set-nullable-fields-as-undefined

  • Elasticsearch: make nullable fields undefinable
    I always prefer null value vs undefined when possible. It forces you to input everything and create stable, unsurprising json structure. However, since elasticsearch stores the full document in the end, it's really wasted storage that quickly adds up. Also, it's probably faster to stringify like this.

  • Dissociate Message and Operation
    Since there is no one structure that fits all, it makes no sense to not differentiate them. The Elasticsearch schema is still the same since it indexes both documents but we now produce different (but compatible) object.

  • Removed code and title from schema
    That were never used

@bodinsamuel bodinsamuel self-assigned this Feb 20, 2025
Copy link

linear bot commented Feb 20, 2025

@bodinsamuel bodinsamuel requested review from khaliqgant and a team February 20, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant