fix(es): make nullable fields undefinable, dissociate Message and Operation #3548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes https://linear.app/nango/issue/NAN-2738/set-nullable-fields-as-undefined
Elasticsearch: make nullable fields undefinable
I always prefer null value vs undefined when possible. It forces you to input everything and create stable, unsurprising json structure. However, since elasticsearch stores the full document in the end, it's really wasted storage that quickly adds up. Also, it's probably faster to stringify like this.
Dissociate Message and Operation
Since there is no one structure that fits all, it makes no sense to not differentiate them. The Elasticsearch schema is still the same since it indexes both documents but we now produce different (but compatible) object.
Removed code and title from schema
That were never used