Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): add support for amazon selling partner api #3538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hassan254-prog
Copy link
Contributor

Describe the problem and your solution

  • Add support for the Amazon Selling Partner API, I split the two, as they have different authorization parameters.

Copy link

linear bot commented Feb 18, 2025

@hassan254-prog hassan254-prog self-assigned this Feb 18, 2025
@hassan254-prog hassan254-prog requested a review from a team February 18, 2025 19:38
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good 👌🏻

- dev-tools
- e-commerce
auth_mode: OAUTH2
authorization_url: https://${connectionConfig.subdomain}.amazon.${connectionConfig.extension}/authorize/consent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easier to just ask for the full domain and enforce the schema subdomain.amazon.tld?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this and implemented the following pattern. @bodinsamuel, could you kindly confirm if this is the best solution?

example: sellercentral.amazon.com
pattern: '^[a-z0-9.-]+\.amazon\.[a-z.]+$'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants