Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional chaining enhancements #134

Closed
wants to merge 1 commit into from

Conversation

deanshub
Copy link

@deanshub deanshub commented Oct 5, 2020

Proposed changes

A more readable coode.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING guide
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@Frenchcooc Frenchcooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal! Most of the code relies on ... && ... and not ?. checks. That would be a tremendous work to review all files and make sure everything is still green.

Also the readibility argument is a point of view. Some may agree, but not sure it's best.

I'm closing that PR. But thanks for the idea!

@Frenchcooc Frenchcooc closed this Oct 5, 2020
nango-repository-pusher bot pushed a commit that referenced this pull request Dec 3, 2024
…sed on changes in NangoHQ/integration-templates@fe1184f by Khaliq. Commit message: fix(lever): more cleanup of endpoints (#134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants