Skip to content

Commit

Permalink
fix(optionals): chaining (#208)
Browse files Browse the repository at this point in the history
## Describe your changes

## Issue ticket number and link

## Checklist before requesting a review (skip if just adding/editing
APIs & templates)

-   [ ] I added tests, otherwise the reason is:
-   [ ] External API requests have `retries`
-   [ ] Pagination is used where appropriate
- [ ] The built in `nango.paginate` call is used instead of a `while
(true)` loop
- [ ] Third party requests are NOT parallelized (this can cause issues
with rate limits)
- [ ] If a sync requires metadata the `nango.yaml` has `auto_start:
false`
-   [ ] If the sync is a `full` sync then `track_deletes: true` is set
- [ ] I followed the best practices and guidelines from the [Writing
Integration
Scripts](/NangoHQ/integration-templates/blob/main/WRITING_INTEGRATION_SCRIPTS.md)
doc
  • Loading branch information
khaliqgant authored Jan 31, 2025
1 parent f922ae9 commit 58c8dad
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion flows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2358,7 +2358,7 @@ integrations:
created_at: string
updated_at: string
event_memberships: EventMembership[]
event_guests: EventGuest[]
event_guests?: EventGuest[]
calendar_event: CalendarEvent | null
cancellation?: EventCancellation
CalendarEvent:
Expand Down
2 changes: 1 addition & 1 deletion integrations/calendly/nango.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ models:
created_at: string
updated_at: string
event_memberships: EventMembership[]
event_guests: EventGuest[]
event_guests?: EventGuest[]
calendar_event: CalendarEvent | null
cancellation?: EventCancellation
CalendarEvent:
Expand Down
2 changes: 1 addition & 1 deletion integrations/calendly/syncs/events.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ _No request body_
"user_name": "<string>"
}
],
"event_guests": [
"event_guests?": [
{
"email": "<string>",
"created_at": "<string>",
Expand Down
4 changes: 2 additions & 2 deletions integrations/jira/helpers/get-cloud-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export async function getCloudData(nango: NangoAction): Promise<{ cloudId: strin
const connection = await nango.getConnection();
const metadata = await nango.getMetadata<JiraIssueMetadata>();

const cloudId = connection.connection_config['cloudId'] ?? metadata.cloudId;
const baseUrl = connection.connection_config['baseUrl'] ?? metadata.baseUrl;
const cloudId = connection.connection_config['cloudId'] ?? metadata?.cloudId;
const baseUrl = connection.connection_config['baseUrl'] ?? metadata?.baseUrl;

if (cloudId && baseUrl) {
return { cloudId, baseUrl };
Expand Down

0 comments on commit 58c8dad

Please sign in to comment.